Change envoy_reloadable_features_http_inspector_use_balsa_parser to default true#44679
Open
reubent-goog wants to merge 3 commits intoenvoyproxy:mainfrom
Open
Change envoy_reloadable_features_http_inspector_use_balsa_parser to default true#44679reubent-goog wants to merge 3 commits intoenvoyproxy:mainfrom
envoy_reloadable_features_http_inspector_use_balsa_parser to default true#44679reubent-goog wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Reuben Tanner <reubent@google.com>
reubent-goog
force-pushed
the
http-inspector
branch
from
bff9834 to
a54e86c
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
CI keeps failing to download dependencies but the tests are passing and this is ready to review |
Contributor
|
Any chance of this TODO getting done before the default gets flipped? This check is implemented poorly so it would be nice if it wasn't rolled out. |
Contributor
Author
Is UHV method validation enabled? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Change
envoy_reloadable_features_http_inspector_use_balsa_parserto default trueAdditional Description: Balsa has been the open source default for a while. We are ready to delete HttpParserImpl code from Envoy but need to migrate this filter first. We begin the 6 month clock now! See the commit and bug which tracked this work.
Risk Level: Low
Testing: Parameterized //test/extensions/filters/listener/http_inspector:http_inspector_integration_test and adjusted expectations based on parser differences. All other tests pass.
Docs Changes: None.
Release Notes: Updated change log.
Platform Specific Features: None.